walterddr commented on code in PR #8757:
URL: https://github.com/apache/pinot/pull/8757#discussion_r882044727
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##########
@@ -84,27 +74,158 @@
/**
* Base class for integration tests that involve a complete Pinot cluster.
+ *
+ * Similar to {@link ControllerTest}, one should entirely encapsulate the
{@code ClusterTest} object as a
+ * singleton within a test group/suite; or instantiate one instance per test
class that requires setup.
*/
public abstract class ClusterTest extends ControllerTest {
Review Comment:
agreed. traditionally `Test*` and `*Test` class names are actually test
cases. so we shouldn't use these as start or end class name for utilities.
see:
https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html.
I will follow up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
