Jackie-Jiang commented on code in PR #8663:
URL: https://github.com/apache/pinot/pull/8663#discussion_r879941962
##########
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##########
@@ -79,6 +82,12 @@ protected Context preprocess() {
context._runSegmentLevelValidation = true;
_lastSegmentLevelValidationRunTimeMs = currentTimeMs;
}
+
+ if
(periodicTaskProperties.containsKey(RECREATE_DELETED_CONSUMING_SEGMENT_KEY)) {
+ context._recreateDeletedConsumingSegment =
+
Boolean.parseBoolean(periodicTaskProperties.getProperty(RECREATE_DELETED_CONSUMING_SEGMENT_KEY));
+ }
Review Comment:
(minor) Can be simplified
```suggestion
context._recreateDeletedConsumingSegment =
Boolean.parseBoolean(periodicTaskProperties.getProperty(RECREATE_DELETED_CONSUMING_SEGMENT_KEY));
```
##########
pinot-common/src/main/java/org/apache/pinot/common/messages/RunPeriodicTaskMessage.java:
##########
@@ -63,4 +70,8 @@ public String getPeriodicTaskName() {
public String getTableNameWithType() {
return getRecord().getSimpleField(TABLE_NAME_WITH_TYPE_KEY);
}
+
+ public Map<String, String> getTaskParams() {
Review Comment:
```suggestion
public Map<String, String> getTaskProperties() {
```
##########
pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTask.java:
##########
@@ -32,6 +32,7 @@ public interface PeriodicTask extends Runnable {
// PeriodicTask objects may take a {@link Properties} object. Define all the
keys property keys here.
String PROPERTY_KEY_REQUEST_ID = "requestId";
String PROPERTY_KEY_TABLE_NAME = "tableNameWithType";
+ String TASK_PARAMS_JSON = "taskParams";
Review Comment:
Revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
