saurabhd336 commented on code in PR #8663:
URL: https://github.com/apache/pinot/pull/8663#discussion_r880069932
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -855,14 +855,21 @@ private Map<Integer, SegmentZKMetadata>
getLatestSegmentZKMetadataMap(String rea
* idealState.
* If so, it should create the new segments in idealState.
*
+ * If the consuming segment is deleted:
+ * Check whether there are segments in the PROPERTYSTORE with status DONE,
but no new segment in status
+ * IN_PROGRESS, and the state for the latest segment in the IDEALSTATE is
ONLINE.
+ * If so, it should create a new CONSUMING segment for the partition.
+ * (this operation is done only if @param recreateDeletedConsumingSegment is
set to true)
+ *
* If the controller fails after step-3, we are fine because the idealState
has the new segments.
* If the controller fails before step-1, the server will see this as an
upload failure, and will re-try.
* @param tableConfig
*
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
