ddcprg commented on code in PR #8774:
URL: https://github.com/apache/pinot/pull/8774#discussion_r882472455
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelStreamConfig.java:
##########
@@ -31,13 +31,16 @@
*/
public class KafkaPartitionLevelStreamConfig {
+ public static final String POPULATE_ROW_METADATA =
"stream.kafka.populateRowMetadata";
Review Comment:
thank you @xiangfu0 @KKcorps for reviewing, would this be generic enough to
move it to `StreamConfigProperties` if I renamed it
`consumption.metadata.populate` or something similar? I've reviewed both Pulsar
and Kinesis stream plugins and this would apply to these 2 as well. Then, I
think the property can be actually documented on the page that @KKcorps has
mentioned above if we do this. I can propagate this changes to Pulsar and
Kinesis in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
