sajjad-moradi commented on code in PR #8774: URL: https://github.com/apache/pinot/pull/8774#discussion_r883130356
########## pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/metadata/KafkaMessageMetadataFactory.java: ########## @@ -0,0 +1,29 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.stream.kafka20.metadata; + +import org.apache.kafka.clients.consumer.ConsumerRecord; + + +public class KafkaMessageMetadataFactory implements MessageMetadataFactory { + @Override + public KafkaMessageMetadata create(ConsumerRecord<?, ?> consumerRecord) { + return new KafkaMessageMetadata(consumerRecord.timestamp()); + } +} Review Comment: This is a little bit confusing as the interface MessageMetadataFactory is specific to kafka (ConsumerRecord argument of the method belongs to kafka) and then the class KafkaMessageMetadataFactory implements that! Since the logic is simple, I would suggest consolidating three classes `MessageMetadataFactory`, `KafkaMessageMetadataFactory`, and `NoopMessageMetadataFactory` into one. Something like the following (I used extractor suffix instead of factory): ```java public interface KafkaMessageMetadataExtractor { KafkaMessageMetadata extract(ConsumerRecord<?, ?> consumerRecord); static KafkaMessageMetadataExtractor build(boolean populateMetadata) { if (populateMetadata) { return record -> new KafkaMessageMetadata(record.timestamp()); } else { return record -> null; } } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
