zhtaoxiang commented on code in PR #8792:
URL: https://github.com/apache/pinot/pull/8792#discussion_r883889697
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java:
##########
@@ -81,6 +82,23 @@ public DateTimeFormatter getDateTimeFormatter() {
return _dateTimeFormatter;
}
+ /**
+ * Validates the sdf pattern
+ */
+ public static void validateFormat(@Nonnull String sdfPatternWithTz) {
Review Comment:
thanks for the suggestions!
The tricky part is that the constructor also need to change some member
variables, while this static method cannot (1) cannot change them (2) can only
return a single value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
