Jackie-Jiang commented on code in PR #8792:
URL: https://github.com/apache/pinot/pull/8792#discussion_r883909932
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java:
##########
@@ -81,6 +82,23 @@ public DateTimeFormatter getDateTimeFormatter() {
return _dateTimeFormatter;
}
+ /**
+ * Validates the sdf pattern
+ */
+ public static void validateFormat(@Nonnull String sdfPatternWithTz) {
Review Comment:
Oh, I see your point. Nvm then.
One small optimization we can do here is to only validate the time zone if
it is specified, and skip the `withZone(dateTimeZone)` which will just create a
separate formatter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
