richardstartin commented on code in PR #8802:
URL: https://github.com/apache/pinot/pull/8802#discussion_r885086533
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java:
##########
@@ -240,7 +240,7 @@ public static void uploadSegment(String tableNameWithType,
BatchConfig batchConf
}
PinotFS outputFileFS = getOutputPinotFS(batchConfig,
outputSegmentDirURI);
Map<String, String> segmentUriToTarPathMap =
SegmentPushUtils.getSegmentUriToTarPathMap(outputSegmentDirURI,
- segmentUploadSpec.getPushJobSpec(), new String[] {
segmentTarURIs.toString() });
+ segmentUploadSpec.getPushJobSpec(),
segmentTarURIStrs.toArray(String[]::new));
Review Comment:
If you change this to new String[0] it will compile at JDK8 source level and
the presto compatibility check will pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
