lksvenoy-r7 commented on code in PR #8802:
URL: https://github.com/apache/pinot/pull/8802#discussion_r886556315
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java:
##########
@@ -240,7 +240,7 @@ public static void uploadSegment(String tableNameWithType,
BatchConfig batchConf
}
PinotFS outputFileFS = getOutputPinotFS(batchConfig,
outputSegmentDirURI);
Map<String, String> segmentUriToTarPathMap =
SegmentPushUtils.getSegmentUriToTarPathMap(outputSegmentDirURI,
- segmentUploadSpec.getPushJobSpec(), new String[] {
segmentTarURIs.toString() });
+ segmentUploadSpec.getPushJobSpec(),
segmentTarURIStrs.toArray(String[]::new));
Review Comment:
> @lksvenoy-r7 - I'm not sure I understand your comment about `All the other
places use the same new String[0]`. Are you saying you think those don't need
to be fixed?
There is nothing to fix, because new String[0] is correct. All the other
methods are doing it correctly, this PR simply makes this method fall inline
with all the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
