richardstartin commented on PR #8846: URL: https://github.com/apache/pinot/pull/8846#issuecomment-1148400449
You don't mention replacing constant time lookups with logarithmic time lookups in `SegmentDictionaryCreator` making this a space/time tradeoff. It would be good to have some numbers to demonstrate the tradeoff is worthwhile, and to mention it in the PR description to help someone track down the root cause of a regression if it happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
