Jackie-Jiang commented on PR #8846: URL: https://github.com/apache/pinot/pull/8846#issuecomment-1159285009
> How do you know how much extra time it takes to build a column based on this benchmark? Shouldn’t it benchmark segment build time instead? This benchmark isolates the steps of map creation + lookup when building a segment with 5M documents. I tried building the segments in the offline integration test, and the time spent is reduced from 4.8s to 3.6s, but that is the combined result of all the changes in this PR. To better testing the performance impact of binary search, I decide to not include that change in this PR, and have a separate one just for the binary search change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
