abhs50 commented on code in PR #8907:
URL: https://github.com/apache/pinot/pull/8907#discussion_r899419574
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -682,7 +685,9 @@ private void logBrokerResponse(long requestId, String
query, RequestContext requ
brokerResponse.getOfflineThreadCpuTimeNs(),
brokerResponse.getOfflineSystemActivitiesCpuTimeNs(),
brokerResponse.getOfflineResponseSerializationCpuTimeNs(),
brokerResponse.getRealtimeTotalCpuTimeNs(),
brokerResponse.getRealtimeThreadCpuTimeNs(),
brokerResponse.getRealtimeSystemActivitiesCpuTimeNs(),
- brokerResponse.getRealtimeResponseSerializationCpuTimeNs(),
StringUtils.substring(query, 0, _queryLogLength));
+ brokerResponse.getRealtimeResponseSerializationCpuTimeNs(),
+ ((HttpRequesterIdentity)
requesterIdentity).getHttpHeaders().toString(),
Review Comment:
I agree. Hence the comment here:
https://github.com/apache/pinot/issues/8869#issuecomment-1157729246
Wanted to see what the community feels about this. If we have specific keys
then it may only solve for a certain set of use cases. For example, if we add
"X-Forwarded-For" for tracking source info, there might be use-cases where
pinot users might be interested in custom headers specific to individual use
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
