abhs50 commented on code in PR #8907:
URL: https://github.com/apache/pinot/pull/8907#discussion_r899442872
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -682,7 +685,9 @@ private void logBrokerResponse(long requestId, String
query, RequestContext requ
brokerResponse.getOfflineThreadCpuTimeNs(),
brokerResponse.getOfflineSystemActivitiesCpuTimeNs(),
brokerResponse.getOfflineResponseSerializationCpuTimeNs(),
brokerResponse.getRealtimeTotalCpuTimeNs(),
brokerResponse.getRealtimeThreadCpuTimeNs(),
brokerResponse.getRealtimeSystemActivitiesCpuTimeNs(),
- brokerResponse.getRealtimeResponseSerializationCpuTimeNs(),
StringUtils.substring(query, 0, _queryLogLength));
+ brokerResponse.getRealtimeResponseSerializationCpuTimeNs(),
+ ((HttpRequesterIdentity)
requesterIdentity).getHttpHeaders().toString(),
Review Comment:
Makes sense. I will change it to have only "X-Forwarded-For" as the key.
Any recommendations on which delimiter to you use to extract values part of
the header. Example : ((HttpRequesterIdentity)
requesterIdentity).getHttpHeaders().get("X-Forwarded-For") returns
Collection<String> and adding the list to the log might conflict with the `,`
separated format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
