snleee commented on code in PR #8911:
URL: https://github.com/apache/pinot/pull/8911#discussion_r903239715
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BaseReduceService.java:
##########
@@ -318,7 +318,7 @@ protected void setStats(String rawTableName,
BrokerResponseNative brokerResponse
brokerMetrics.addTimedTableValue(rawTableName,
BrokerTimer.REALTIME_TOTAL_CPU_TIME_NS, _realtimeTotalCpuTimeNs,
TimeUnit.NANOSECONDS);
- if (_numConsumingSegmentsProcessed > 0 && _minConsumingFreshnessTimeMs
> 0) {
+ if (_minConsumingFreshnessTimeMs != Long.MAX_VALUE) {
Review Comment:
@PrachiKhobragade We can probably put it as the following to exactly show
what we would like to achieve?
```
if (_numConsumingSegmentsProcessed > 0 || (_numConsumingSegmentsProcessed ==
0 && _minConsumingFreshnessTimeMs != Long.MAX_VALUE)) {
...
}
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
