snleee commented on code in PR #8911:
URL: https://github.com/apache/pinot/pull/8911#discussion_r921692258
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -195,19 +198,35 @@ private DataTable processQueryInternal(ServerQueryRequest
queryRequest, Executor
// Gather stats for realtime consuming segments
int numConsumingSegments = 0;
- long minIndexTimeMs = Long.MAX_VALUE;
- long minIngestionTimeMs = Long.MAX_VALUE;
- for (IndexSegment indexSegment : indexSegments) {
- if (indexSegment instanceof MutableSegment) {
- numConsumingSegments += 1;
- SegmentMetadata segmentMetadata = indexSegment.getSegmentMetadata();
- long indexTimeMs = segmentMetadata.getLastIndexedTimestamp();
- if (indexTimeMs != Long.MIN_VALUE && indexTimeMs < minIndexTimeMs) {
- minIndexTimeMs = indexTimeMs;
- }
- long ingestionTimeMs = segmentMetadata.getLatestIngestionTimestamp();
- if (ingestionTimeMs != Long.MIN_VALUE && ingestionTimeMs <
minIngestionTimeMs) {
- minIngestionTimeMs = ingestionTimeMs;
+ int numOnlineSegments = 0;
+ long minIndexTimeMs = 0;
+ long minIngestionTimeMs = 0;
+ long maxEndTimeMs = 0;
+ if (tableDataManager instanceof RealtimeTableDataManager) {
+ numConsumingSegments = 0;
+ numOnlineSegments = 0;
+ minIndexTimeMs = Long.MAX_VALUE;
+ minIngestionTimeMs = Long.MAX_VALUE;
+ maxEndTimeMs = Long.MIN_VALUE;
+ for (IndexSegment indexSegment : indexSegments) {
+ if (indexSegment instanceof MutableSegment) {
+ numConsumingSegments += 1;
+ SegmentMetadata segmentMetadata = indexSegment.getSegmentMetadata();
+ long indexTimeMs = segmentMetadata.getLastIndexedTimestamp();
+ if (indexTimeMs != Long.MIN_VALUE && indexTimeMs < minIndexTimeMs) {
+ minIndexTimeMs = indexTimeMs;
+ }
+ long ingestionTimeMs = segmentMetadata.getLatestIngestionTimestamp();
+ if (ingestionTimeMs != Long.MIN_VALUE && ingestionTimeMs <
minIngestionTimeMs) {
+ minIngestionTimeMs = ingestionTimeMs;
+ }
+ } else if (indexSegment instanceof ImmutableSegment) {
+ SegmentMetadata segmentMetadata = indexSegment.getSegmentMetadata();
+ Interval timeInterval = segmentMetadata.getTimeInterval();
+ numOnlineSegments++;
+ if (timeInterval != null) {
+ maxEndTimeMs = Math.max(maxEndTimeMs, timeInterval.getEndMillis());
Review Comment:
@sajjad-moradi Your statement applies to `MutableSegment`. In that case, we
call `getLastIndexedTimestamp() / getLatestIngestionTimestamp()`. We call
`getTimeInverval()` for `ImmutableSegment`. In this case, it indeed returns the
correct start/end time of the segment.
```
SegmentMetadataImple:setTimeInfo()
_segmentStartTime = Long.parseLong(startTimeString);
_segmentEndTime = Long.parseLong(endTimeString);
_timeInterval =
new Interval(_timeUnit.toMillis(_segmentStartTime),
_timeUnit.toMillis(_segmentEndTime), DateTimeZone.UTC);
```
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -195,19 +198,35 @@ private DataTable processQueryInternal(ServerQueryRequest
queryRequest, Executor
// Gather stats for realtime consuming segments
int numConsumingSegments = 0;
- long minIndexTimeMs = Long.MAX_VALUE;
- long minIngestionTimeMs = Long.MAX_VALUE;
- for (IndexSegment indexSegment : indexSegments) {
- if (indexSegment instanceof MutableSegment) {
- numConsumingSegments += 1;
- SegmentMetadata segmentMetadata = indexSegment.getSegmentMetadata();
- long indexTimeMs = segmentMetadata.getLastIndexedTimestamp();
- if (indexTimeMs != Long.MIN_VALUE && indexTimeMs < minIndexTimeMs) {
- minIndexTimeMs = indexTimeMs;
- }
- long ingestionTimeMs = segmentMetadata.getLatestIngestionTimestamp();
- if (ingestionTimeMs != Long.MIN_VALUE && ingestionTimeMs <
minIngestionTimeMs) {
- minIngestionTimeMs = ingestionTimeMs;
+ int numOnlineSegments = 0;
+ long minIndexTimeMs = 0;
+ long minIngestionTimeMs = 0;
+ long maxEndTimeMs = 0;
+ if (tableDataManager instanceof RealtimeTableDataManager) {
+ numConsumingSegments = 0;
+ numOnlineSegments = 0;
+ minIndexTimeMs = Long.MAX_VALUE;
+ minIngestionTimeMs = Long.MAX_VALUE;
+ maxEndTimeMs = Long.MIN_VALUE;
+ for (IndexSegment indexSegment : indexSegments) {
+ if (indexSegment instanceof MutableSegment) {
+ numConsumingSegments += 1;
+ SegmentMetadata segmentMetadata = indexSegment.getSegmentMetadata();
+ long indexTimeMs = segmentMetadata.getLastIndexedTimestamp();
+ if (indexTimeMs != Long.MIN_VALUE && indexTimeMs < minIndexTimeMs) {
+ minIndexTimeMs = indexTimeMs;
+ }
+ long ingestionTimeMs = segmentMetadata.getLatestIngestionTimestamp();
+ if (ingestionTimeMs != Long.MIN_VALUE && ingestionTimeMs <
minIngestionTimeMs) {
+ minIngestionTimeMs = ingestionTimeMs;
+ }
+ } else if (indexSegment instanceof ImmutableSegment) {
+ SegmentMetadata segmentMetadata = indexSegment.getSegmentMetadata();
+ Interval timeInterval = segmentMetadata.getTimeInterval();
+ numOnlineSegments++;
+ if (timeInterval != null) {
+ maxEndTimeMs = Math.max(maxEndTimeMs, timeInterval.getEndMillis());
Review Comment:
@sajjad-moradi Your statement applies to `MutableSegment`. In that case, we
call `getLastIndexedTimestamp() / getLatestIngestionTimestamp()`. We call
`getTimeInverval()` for `ImmutableSegment`. In this case, it indeed returns the
correct start/end time of the segment.
```
SegmentMetadataImpl:setTimeInfo()
_segmentStartTime = Long.parseLong(startTimeString);
_segmentEndTime = Long.parseLong(endTimeString);
_timeInterval =
new Interval(_timeUnit.toMillis(_segmentStartTime),
_timeUnit.toMillis(_segmentEndTime), DateTimeZone.UTC);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
