siddharthteotia commented on code in PR #9004:
URL: https://github.com/apache/pinot/pull/9004#discussion_r916349564
##########
pinot-core/src/main/java/org/apache/pinot/core/common/evaluators/DefaultJsonPathEvaluator.java:
##########
@@ -90,7 +90,7 @@ public <T extends ForwardIndexReaderContext> void
evaluateBlock(int[] docIds, in
}
}
} else {
- switch (reader.getValueType()) {
+ switch (reader.getStoredType()) {
Review Comment:
Secondly, if we make this change do we still need `getValueType` anywhere in
the code to get the actual logical datatype of the column ? I guess no because
`ForwardIndexReader` and it's users should only need to work with `storedType`
except for `DefaultIndexReaderProvider` code ?
Also, for columns like BOOLEAN / TIMESTAMP, this change should have ideally
failed some tests whose storedType is INT / LONG because now the return value
is different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
