Jackie-Jiang commented on code in PR #9004:
URL: https://github.com/apache/pinot/pull/9004#discussion_r918331715
##########
pinot-core/src/main/java/org/apache/pinot/core/common/evaluators/DefaultJsonPathEvaluator.java:
##########
@@ -90,7 +90,7 @@ public <T extends ForwardIndexReaderContext> void
evaluateBlock(int[] docIds, in
}
}
} else {
- switch (reader.getValueType()) {
+ switch (reader.getStoredType()) {
Review Comment:
Forward index only knows the stored type of the value, and it doesn't know
the logical type of the value.
For the `JSON` branch under the switch, I believe they are never hit, and
`getStoredType()` should never return `JSON`. We can try removing the `JSON`
branch and see if all the tests still pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
