nizarhejazi commented on code in PR #8927: URL: https://github.com/apache/pinot/pull/8927#discussion_r921764722
########## pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawDoubleSingleColumnDistinctExecutor.java: ########## @@ -39,13 +39,17 @@ abstract class BaseRawDoubleSingleColumnDistinctExecutor implements DistinctExec final ExpressionContext _expression; final DataType _dataType; final int _limit; + final boolean _nullHandlingEnabled; final DoubleSet _valueSet; + int _numNulls; Review Comment: marked as `protected` to avoid calling a setter method. Renamed to `_hasNll`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
