nizarhejazi commented on code in PR #8927: URL: https://github.com/apache/pinot/pull/8927#discussion_r921831490
########## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/NoDictionarySingleColumnGroupKeyGenerator.java: ########## @@ -51,16 +53,20 @@ public class NoDictionarySingleColumnGroupKeyGenerator implements GroupKeyGenera private final DataType _storedType; private final Map _groupKeyMap; private final int _globalGroupIdUpperBound; + private final boolean _nullHandlingEnabled; Review Comment: Added TODO. Will address in next PR since this one became big. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
