siddharthteotia commented on code in PR #9131:
URL: https://github.com/apache/pinot/pull/9131#discussion_r932975157
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapperTest.java:
##########
@@ -802,6 +802,57 @@ public void testArrayConcatIntTransformFunction() {
testTransformFunctionMV(transformFunction, expectedValues);
}
+ @Test
Review Comment:
Please also consider adding some other query execution tests. Take a look at
`BaseMultiValueQueriesTest` or `OfflineClusterIntegrationTest` to add such
tests.
Example cases ...
**Nest the function**
```
SELECT arraylength(arrayConcatInt(mvIntCol1, mvIntCol2))
FROM FOO
```
```
SELECT arraySortInt(arrayConcatInt(mvIntCol1, mvIntCol2))
FROM FOO
```
**Use the output of the expression in WHERE clause**
```
SELECT arrayConcatInt(mvIntCol1, mvIntCol2) AS concatenated
FROM FOO
WHERE arrayLength(concatenated) >= 2
```
**Use in GROUP BY**
```
SELECT arrayConcatInt(mvIntCol1, mvIntCol2) AS concatenated, sum(intcol)
FROM FOO
WHERE arrayLength(concatenated) >= 2
GROUP BY concatenated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
