siddharthteotia commented on code in PR #9131:
URL: https://github.com/apache/pinot/pull/9131#discussion_r933496688
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapperTest.java:
##########
@@ -802,6 +802,57 @@ public void testArrayConcatIntTransformFunction() {
testTransformFunctionMV(transformFunction, expectedValues);
}
+ @Test
Review Comment:
> such tests do not exists for the currently supported functions like
arrayConcatInt and arrayConcatString, right?
I think that is correct (most likely). But we will have to dig through since
tests are spread across so many files unfortunately.
> If that is the case I can look into adding these tests for the new
functions being added in this PR
Yes, in the PR I suggest adding tests only for new functions. Separate PR
can be filed to add more tests for existing functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
