walterddr commented on code in PR #9202:
URL: https://github.com/apache/pinot/pull/9202#discussion_r944033369
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -190,26 +191,34 @@ public BrokerResponseNative handleRequest(JsonNode
request, @Nullable RequesterI
if (sql == null) {
throw new BadQueryRequestException("Failed to find 'sql' in the request:
" + request);
}
- return handleRequest(requestId, sql.asText(), request, requesterIdentity,
requestContext);
+ String query = sql.asText();
+ requestContext.setQuery(query);
+ return handleRequest(requestId, query, sqlNodeAndOptions,
compilationStartTimeNs, request, requesterIdentity,
+ requestContext);
}
- private BrokerResponseNative handleRequest(long requestId, String query,
JsonNode request,
+ private BrokerResponseNative handleRequest(long requestId, String query,
+ @Nullable SqlNodeAndOptions sqlNodeAndOptions, long
compilationStartTimeNs, JsonNode request,
Review Comment:
passing in compilationStartTimeNs is kinda weird here. let's just break this
into parser time and still keep the `compilationStartTimeNs` inside the
handleRequest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
