siddharthteotia commented on code in PR #9202:
URL: https://github.com/apache/pinot/pull/9202#discussion_r944624652
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -190,27 +191,32 @@ public BrokerResponseNative handleRequest(JsonNode
request, @Nullable RequesterI
if (sql == null) {
throw new BadQueryRequestException("Failed to find 'sql' in the request:
" + request);
}
- return handleRequest(requestId, sql.asText(), request, requesterIdentity,
requestContext);
+ String query = sql.asText();
+ requestContext.setQuery(query);
+ return handleRequest(requestId, query, sqlNodeAndOptions, request,
requesterIdentity, requestContext);
}
- private BrokerResponseNative handleRequest(long requestId, String query,
JsonNode request,
- @Nullable RequesterIdentity requesterIdentity, RequestContext
requestContext)
+ private BrokerResponseNative handleRequest(long requestId, String query,
+ @Nullable SqlNodeAndOptions sqlNodeAndOptions, JsonNode request,
@Nullable RequesterIdentity requesterIdentity,
+ RequestContext requestContext)
throws Exception {
LOGGER.debug("SQL query for request {}: {}", requestId, query);
- requestContext.setQuery(query);
// Compile the request
- long compilationStartTimeNs = System.nanoTime();
PinotQuery pinotQuery;
try {
- pinotQuery = CalciteSqlParser.compileToPinotQuery(query);
+ if (sqlNodeAndOptions == null) {
Review Comment:
So callers like us (LinkedIn) will pass this as NULL and it should continue
to work IIUC. We call handleRequest and let it parse and compile query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
