Jackie-Jiang commented on code in PR #9271:
URL: https://github.com/apache/pinot/pull/9271#discussion_r953156737
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -498,8 +498,7 @@ protected boolean consumeLoop()
* otherwise
*/
private boolean processStreamEvents(MessageBatch messagesAndOffsets, long
idlePipeSleepTimeMillis) {
-
- int messageCount = messagesAndOffsets.getUnfilteredMessageCount();
+ int messageCount = messagesAndOffsets.getMessageCount();
_rateLimiter.throttle(messageCount);
Review Comment:
@sajjad-moradi IMO the rate limiter should be applied to the filtered
messages instead of unfiltered messages because the purpose of it is to limit
the ingestion rate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
