sajjad-moradi commented on code in PR #9271:
URL: https://github.com/apache/pinot/pull/9271#discussion_r953174637
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -498,8 +498,7 @@ protected boolean consumeLoop()
* otherwise
*/
private boolean processStreamEvents(MessageBatch messagesAndOffsets, long
idlePipeSleepTimeMillis) {
-
- int messageCount = messagesAndOffsets.getUnfilteredMessageCount();
+ int messageCount = messagesAndOffsets.getMessageCount();
_rateLimiter.throttle(messageCount);
Review Comment:
Since we don't provide any end.offset when we fetch messages, the only
filtered out message type is the null message. Since we don't do any processing
with those messages, it's ok to not count them towards rate limiting (although
we've actually fetched them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
