61yao commented on code in PR #9265:
URL: https://github.com/apache/pinot/pull/9265#discussion_r953221296
##########
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/spec/SegmentGenerationJobSpec.java:
##########
@@ -45,6 +45,11 @@ public class SegmentGenerationJobSpec implements
Serializable {
*/
private String _inputDirURI;
+ /**
+ * If true, search input files recursively from root directly specified in
_inputDirURI.
+ */
+ // TODO: set the default value to false after all clients are aware of this.
+ private boolean _searchRecursively = true;
Review Comment:
Done
##########
pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/spec/SegmentGenerationJobSpec.java:
##########
@@ -161,6 +166,13 @@ public void setInputDirURI(String inputDirURI) {
_inputDirURI = inputDirURI;
}
+ public boolean isSearchRecursively() {
+ return _searchRecursively;
+ }
+
+ public void setSearchRecursively(boolean searchRecursively) {
+ _searchRecursively = searchRecursively;
+ }
Review Comment:
Done
##########
pinot-common/src/main/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtils.java:
##########
@@ -229,4 +233,63 @@ private static String fetchUrl(URL url, String authToken)
}
return IOUtils.toString(connection.getInputStream(),
StandardCharsets.UTF_8);
}
+
+
+ /**
+ * Find matching files from root directory specified in fileUri.
+ * If includePattern and excludePattern are not null, get all the files that
match includePattern and exclude files
+ * that match excludePattern.
+ * If
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
