61yao commented on code in PR #9265:
URL: https://github.com/apache/pinot/pull/9265#discussion_r953221495
##########
pinot-common/src/main/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtils.java:
##########
@@ -229,4 +233,63 @@ private static String fetchUrl(URL url, String authToken)
}
return IOUtils.toString(connection.getInputStream(),
StandardCharsets.UTF_8);
}
+
+
+ /**
+ * Find matching files from root directory specified in fileUri.
+ * If includePattern and excludePattern are not null, get all the files that
match includePattern and exclude files
+ * that match excludePattern.
+ * If
+ *
+ * @param pinotFs root directly fs
Review Comment:
Yeah. Typo
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark/SparkSegmentGenerationJobRunner.java:
##########
@@ -128,14 +126,6 @@ public void run()
for (PinotFSSpec pinotFSSpec : pinotFSSpecs) {
PinotFSFactory.register(pinotFSSpec.getScheme(),
pinotFSSpec.getClassName(), new PinotConfiguration(pinotFSSpec));
}
-
- //Get pinotFS for input
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
