yuanbenson commented on code in PR #9309:
URL: https://github.com/apache/pinot/pull/9309#discussion_r964211022
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java:
##########
@@ -44,6 +40,13 @@
*/
public class OfflineSegmentAssignment extends BaseSegmentAssignment {
Review Comment:
(nit), while it may not make sense for `RealtimeSegmentAssignment`, for
`OfflineSegmentAssignment`, we can consider making
`InstancePartitionsType.OFFLINE` an instance variable as it is referenced 9
times in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
