KKcorps commented on code in PR #9377:
URL: https://github.com/apache/pinot/pull/9377#discussion_r970777437
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##########
@@ -222,27 +226,42 @@ public void build()
TransformPipeline.Result reusedResult = new TransformPipeline.Result();
while (_recordReader.hasNext()) {
long recordReadStartTime = System.currentTimeMillis();
- long recordReadStopTime;
+ long recordReadStopTime = System.currentTimeMillis();
long indexStopTime;
reuse.clear();
- GenericRow decodedRow = _recordReader.next(reuse);
- recordReadStartTime = System.currentTimeMillis();
- _transformPipeline.processRow(decodedRow, reusedResult);
- recordReadStopTime = System.currentTimeMillis();
- _totalRecordReadTime += (recordReadStopTime - recordReadStartTime);
+ try {
+ GenericRow decodedRow = _recordReader.next(reuse);
+ recordReadStartTime = System.currentTimeMillis();
+ _transformPipeline.processRow(decodedRow, reusedResult);
+ recordReadStopTime = System.currentTimeMillis();
+ _totalRecordReadTime += (recordReadStopTime - recordReadStartTime);
+ } catch (Exception e) {
+ if (_continueOnError) {
+ incompleteRowsFound++;
+ LOGGER.debug("Error occurred while reading row during indexing",
e);
+ continue;
+ }
+ }
Review Comment:
Yes, you are correct. If it is not set then we need to re-throw the error
and stop ingestion. Let me fix it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
