sajjad-moradi commented on PR #9377: URL: https://github.com/apache/pinot/pull/9377#issuecomment-1247311596
> > This PR only handles segment generation part. We need to take care of the realtime ingestion as well. > > Agreed. The reason I haven't tackled it in this PR is because it is not clear what user can do to fix missing data in case we ignore it in realtime-ingestion. IMO it should be up to users. If they set `continueOnError` to true, they have agreed that's the behavior they want, so RT ingestion continues. If they don't set it or if they set it to false, then ingestion stops and they'll take care of the issue right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
