jackjlli commented on code in PR #9424:
URL: https://github.com/apache/pinot/pull/9424#discussion_r975609836
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1528,8 +1520,8 @@ private void makeStreamMetadataProvider(String reason) {
if (_streamMetadataProvider != null) {
closeStreamMetadataProvider();
}
- _segmentLogger.info("Creating new stream metadata provider, reason: {}",
reason);
- _streamMetadataProvider =
_streamConsumerFactory.createStreamMetadataProvider(_clientId);
+ _segmentLogger.info("Creating new partition metadata provider, reason:
{}", reason);
+ _streamMetadataProvider =
_streamConsumerFactory.createPartitionMetadataProvider(_clientId,
_partitionGroupId);
Review Comment:
> I don't know why an interface called StreamMetadataProvider contains a
method for both createStreamMetadataProvider (stream-level) and
createPartitionMetadataProvider (partition-level).
You mean `StreamConsumerFactory` right?
Just taking a closer look, this class is called
`HLRealtimeSegmentDataManager`, which is a high level data manager for realtime
segment. So it should use the stream-level instead of the partition-level
provider. @navina We should revert this change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
