jackjlli commented on code in PR #9424:
URL: https://github.com/apache/pinot/pull/9424#discussion_r976816855
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1528,8 +1520,8 @@ private void makeStreamMetadataProvider(String reason) {
if (_streamMetadataProvider != null) {
closeStreamMetadataProvider();
}
- _segmentLogger.info("Creating new stream metadata provider, reason: {}",
reason);
- _streamMetadataProvider =
_streamConsumerFactory.createStreamMetadataProvider(_clientId);
+ _segmentLogger.info("Creating new partition metadata provider, reason:
{}", reason);
+ _streamMetadataProvider =
_streamConsumerFactory.createPartitionMetadataProvider(_clientId,
_partitionGroupId);
Review Comment:
Sorry for the late comment here. Somehow I forgot to submit the review
yesterday.
By taking a closer look, the purpose of `_streamMetadataProvider` is to
fetch the latest value of partitionCount from the stream provider, which
shouldn't associate with any particular partitionId here. We should stick to
using the stream-level stream metadata provider here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
