klsince commented on code in PR #9306:
URL: https://github.com/apache/pinot/pull/9306#discussion_r979092597
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -329,7 +330,8 @@ public Map<String, SegmentErrorInfo> getSegmentErrors() {
public void reloadSegment(String segmentName, IndexLoadingConfig
indexLoadingConfig, SegmentZKMetadata zkMetadata,
SegmentMetadata localMetadata, @Nullable Schema schema, boolean
forceDownload)
throws Exception {
- File indexDir = getSegmentDataDir(segmentName);
+ String segmentTier = getSegmentCurrentTier(segmentName);
Review Comment:
I thought about using SegmentMetadataImpl at beginning, but I see its
content is all from the metadata.properties file, so I assume it's used as an
(effective) immutable object. And MutableSegment has SegmentMetadataImpl object
too, but it doesn't have tier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
