klsince commented on code in PR #9306:
URL: https://github.com/apache/pinot/pull/9306#discussion_r995117637
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -200,22 +196,11 @@ public void onBecomeDroppedFromOffline(Message message,
NotificationContext cont
_logger.info("SegmentOnlineOfflineStateModel.onBecomeDroppedFromOffline() : " +
message);
String tableNameWithType = message.getResourceName();
String segmentName = message.getPartitionName();
-
- // This method might modify the file on disk. Use segment lock to
prevent race condition
- Lock segmentLock = SegmentLocks.getSegmentLock(tableNameWithType,
segmentName);
Review Comment:
locked inside dropSegment() method, like the other methods reloadSegment or
so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
