somandal commented on code in PR #9454:
URL: https://github.com/apache/pinot/pull/9454#discussion_r981424317
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -215,6 +218,26 @@ private void extractFromTableConfig(TableConfig
tableConfig) {
}
}
+ /**
+ * Extracts compressionType for each column. Populates a map containing
column name as key and compression type as
+ * value. Note that only RAW forward index columns will be populated in this
map.
+ * @param tableConfig table config
+ */
+ private void extractCompressionConfigs(TableConfig tableConfig) {
Review Comment:
I see your point, but IMO we should first tackle migrating everyone and then
cleaning up the code to stop looking at the older compression codec flag. We
can perhaps establish a precedence ordering that if `fieldConfig` type
compression codec is present it overrides the old config. The old mechanism is
honored when adding a new column and for new segments that get created. So it's
just a bit confusing that we honor it there but not here.
That said, I don't have a very strong opinion on this, since even if
customers do the wrong thing by updating the older flag we can recommend them
to use the new `fieldConfig` way to update the compression codec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
