siddharthteotia commented on code in PR #9454:
URL: https://github.com/apache/pinot/pull/9454#discussion_r982063912
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java:
##########
@@ -450,6 +482,15 @@ private void checkIndexCreation(ColumnIndexType indexType,
String column, int ca
SegmentDirectory.Reader reader = segmentDirectory1.createReader()) {
assertTrue(reader.hasIndexFor(column, indexType));
assertTrue(reader.hasIndexFor(column, ColumnIndexType.FORWARD_INDEX));
+
+ // Check if the raw forward index compressionType is correct.
Review Comment:
You probably explained why this is not necessary / can't be done but I am
still thinking if it should be done.
A test to check that `index_map` file has exactly one entry for column's fwd
index and the entry's start offset > what it was before reload / change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]