walterddr commented on code in PR #9448:
URL: https://github.com/apache/pinot/pull/9448#discussion_r982963752
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java:
##########
@@ -37,8 +37,8 @@ private PinotQueryRuleSets() {
EnumerableRules.ENUMERABLE_PROJECT_RULE,
EnumerableRules.ENUMERABLE_SORT_RULE,
EnumerableRules.ENUMERABLE_TABLE_SCAN_RULE,
- // push a filter into a join, replaced CoreRules.FILTER_INTO_JOIN
with special config
- PinotFilterIntoJoinRule.INSTANCE,
+ // push a filter into a join
+ CoreRules.FILTER_INTO_JOIN,
Review Comment:
most of the rules "available but not use" generally means one of the other
- they work best with cost factory that's not a dummy
- they might cause sideeffect we don't want
thus we leave that out due to "preserve correctness over performant" rule
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java:
##########
@@ -37,8 +37,8 @@ private PinotQueryRuleSets() {
EnumerableRules.ENUMERABLE_PROJECT_RULE,
EnumerableRules.ENUMERABLE_SORT_RULE,
EnumerableRules.ENUMERABLE_TABLE_SCAN_RULE,
- // push a filter into a join, replaced CoreRules.FILTER_INTO_JOIN
with special config
- PinotFilterIntoJoinRule.INSTANCE,
+ // push a filter into a join
+ CoreRules.FILTER_INTO_JOIN,
Review Comment:
most of the rules "available but not use" generally means one of the other
- they work best with cost factory that's not a dummy
- they might cause sideeffect we don't want
thus we leave that out due to "preserve correctness over performant" rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
