walterddr commented on code in PR #9448:
URL: https://github.com/apache/pinot/pull/9448#discussion_r982964155
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -132,7 +139,11 @@ private TransferableBlock
buildJoinedDataBlock(TransferableBlock leftBlock)
List<Object[]> hashCollection = _broadcastHashTable.getOrDefault(
_leftKeySelector.computeHash(leftRow), Collections.emptyList());
for (Object[] rightRow : hashCollection) {
- rows.add(joinRow(leftRow, rightRow));
+ Object[] resultRow = joinRow(leftRow, rightRow);
+ if (_joinClauseEvaluators.isEmpty() ||
_joinClauseEvaluators.stream().allMatch(
Review Comment:
calcite automatically splits into join keys and non-eq join conditions; we
already have a test for this. see QueryRunnerTest (remember WHERE clause pulled
up is applied if predicate involve columns on both table)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
