agavra commented on code in PR #9560:
URL: https://github.com/apache/pinot/pull/9560#discussion_r995167895
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperator.java:
##########
@@ -79,6 +79,12 @@ public
MailboxReceiveOperator(MailboxService<Mailbox.MailboxContent> mailboxServ
singletonInstance = serverInstance;
}
}
+
+ // FIXME: there's a bug where singletonInstance may be null in the case
of a JOIN where
+ // one side is BROADCAST and the other is SINGLETON (this is the case
with nested loop
+ // joins for inequality conditions). This causes NPEs in the logs, but
actually works
+ // because the side that hits the NPE doesn't expect to get any data
anyway (that's the
+ // side that gets the broadcast from one side but nothing from the
SINGLETON)
Review Comment:
https://github.com/apache/pinot/issues/9592 - added to comment as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
