walterddr commented on code in PR #9560:
URL: https://github.com/apache/pinot/pull/9560#discussion_r997218960
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -87,7 +87,7 @@ public void init(PinotConfiguration config,
InstanceDataManager instanceDataMana
_serverExecutor = new ServerQueryExecutorV1Impl();
_serverExecutor.init(config, instanceDataManager, serverMetrics);
_workerExecutor = new WorkerQueryExecutor();
- _workerExecutor.init(config, serverMetrics, _mailboxService, _hostname,
_port);
+ _workerExecutor.init(_mailboxService, _hostname, _port);
Review Comment:
could you revert this change?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/WorkerQueryExecutor.java:
##########
@@ -62,16 +41,11 @@
*/
public class WorkerQueryExecutor {
private static final Logger LOGGER =
LoggerFactory.getLogger(WorkerQueryExecutor.class);
- private PinotConfiguration _config;
- private ServerMetrics _serverMetrics;
private MailboxService<Mailbox.MailboxContent> _mailboxService;
private String _hostName;
private int _port;
- public void init(PinotConfiguration config, ServerMetrics serverMetrics,
- MailboxService<Mailbox.MailboxContent> mailboxService, String hostName,
int port) {
- _config = config;
- _serverMetrics = serverMetrics;
+ public void init(MailboxService<Mailbox.MailboxContent> mailboxService,
String hostName, int port) {
Review Comment:
can you revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
