agavra opened a new pull request, #9600: URL: https://github.com/apache/pinot/pull/9600
Some inspiration: #9397 This PR is a reference PR for a set of PRs that will follow breaking this down into less hacky, reviewable patches - it gives context in case reviewers are interested in what will come after :) Changes: - add backwards compatibility flags in `FunctionInfo` and `ScalarFunction` annotation to existing functions which define all the weird behaviors we have in the original function resolution logic - adds implicit type casting based on the backwards compat flags (see logic in `FunctionRegistry`) - convenience methods for type inference in `ExpressionTypeUtil` - includes a hacky way to get tests to pass that didn't pass schemas into function resolution by just inferring it from the generic row - piped down types everywhere it was necessary This change **SHOULD NOT BE MERGED** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
