agavra commented on code in PR #9600:
URL: https://github.com/apache/pinot/pull/9600#discussion_r997257827
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -106,12 +156,16 @@ public static void registerFunction(Method method,
boolean nullableParameters) {
/**
* Registers a method with the given function name.
*/
- public static void registerFunction(String functionName, Method method,
boolean nullableParameters) {
- FunctionInfo functionInfo = new FunctionInfo(method,
method.getDeclaringClass(), nullableParameters);
+ public static void registerFunction(String functionName, Method method,
boolean nullableParameters, boolean narrowing,
Review Comment:
see comment above, Calcite has a functionality to support type coercion,
which will basically allow you to cast nearly any sql type to another sql type
if you pass in `coerce = true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
