KKcorps commented on code in PR #9527:
URL: https://github.com/apache/pinot/pull/9527#discussion_r1000586768
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -319,23 +319,33 @@ private boolean
createDictionaryForColumn(ColumnIndexCreationInfo info, SegmentG
return false;
}
- // Do not create dictionary if index size with dictionary is going to be
larger than index size without dictionary
- // This is done to reduce the cost of dictionary for high cardinality
columns
- // Off by default and needs optimizeDictionaryEnabled to be set to true
- if (config.isOptimizeDictionaryForMetrics() && spec.getFieldType() ==
FieldType.METRIC && spec.isSingleValueField()
- && spec.getDataType().isFixedWidth()) {
- long dictionarySize = info.getDistinctValueCount() *
spec.getDataType().size();
- long forwardIndexSize =
- ((long) info.getTotalNumberOfEntries() *
PinotDataBitSet.getNumBitsPerValue(info.getDistinctValueCount() - 1)
- + Byte.SIZE - 1) / Byte.SIZE;
-
- double indexWithDictSize = dictionarySize + forwardIndexSize;
- double indexWithoutDictSize = info.getTotalNumberOfEntries() *
spec.getDataType().size();
-
- double indexSizeRatio = indexWithoutDictSize / indexWithDictSize;
- if (indexSizeRatio <= config.getNoDictionarySizeRatioThreshold()) {
+
+
+ if (config.isOptimizeDictionary()) {
Review Comment:
I don't want to keep multiple flags as it creates a lot of confusion for new
users. Also afaik, this config is pretty new (introduced in 0.10) and is not
used by a lot of folks. I understand your concern though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
