KKcorps commented on code in PR #9527:
URL: https://github.com/apache/pinot/pull/9527#discussion_r1008327652
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##########
@@ -55,10 +55,11 @@ public class IndexingConfig extends BaseJsonConfig {
private boolean _nullHandlingEnabled;
/**
- * If `optimizeDictionaryForMetrics` enabled, dictionary is not created for
the metric columns
- * for which rawIndexSize / forwardIndexSize is less than the
`noDictionarySizeRatioThreshold`.
+ * If `optimizeDictionaryForMetrics` enabled, dictionary is not created for
the high-cardinality
+ * single-valued columns for which rawIndexSize / forwardIndexSize is less
than the `noDictionarySizeRatioThreshold`.
+ * It also disables dictionary for json and text columns.
*/
- private boolean _optimizeDictionaryForMetrics;
+ private boolean _optimizeDictionary;
Review Comment:
I think that is out of scope for this PR. That will anyways not be a boolean
config so we can decide on that later. The config name for that would be more
like `dictionaryType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
