jackjlli commented on code in PR #9656:
URL: https://github.com/apache/pinot/pull/9656#discussion_r1005013762
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java:
##########
@@ -201,7 +201,7 @@ void sendRequestWithoutLocking(String rawTableName,
AsyncQueryResponse asyncQuer
ServerRoutingInstance serverRoutingInstance, byte[] requestBytes) {
long startTimeMs = System.currentTimeMillis();
_channel.writeAndFlush(Unpooled.wrappedBuffer(requestBytes)).addListener(f -> {
- long requestSentLatencyMs = System.currentTimeMillis() - startTimeMs;
+ int requestSentLatencyMs = (int) (System.currentTimeMillis() -
startTimeMs);
Review Comment:
Minor suggestion: in Line 205, the integer would still need to be converted
to of long type. How about adding the `(int)` only in Line 207?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
