jackjlli commented on code in PR #9656:
URL: https://github.com/apache/pinot/pull/9656#discussion_r1005057590
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java:
##########
@@ -201,7 +201,7 @@ void sendRequestWithoutLocking(String rawTableName,
AsyncQueryResponse asyncQuer
ServerRoutingInstance serverRoutingInstance, byte[] requestBytes) {
long startTimeMs = System.currentTimeMillis();
_channel.writeAndFlush(Unpooled.wrappedBuffer(requestBytes)).addListener(f -> {
- long requestSentLatencyMs = System.currentTimeMillis() - startTimeMs;
+ int requestSentLatencyMs = (int) (System.currentTimeMillis() -
startTimeMs);
Review Comment:
I thought one of the purposes of this PR is to improve performance of the
query part (e.g. by allocating less heap mem on initiating a int), so that's
why I suggest this as well, as it helps reduce one round of data type
conversion. But I'm fine with the current code change in this PR. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
