siddharthteotia commented on code in PR #9740:
URL: https://github.com/apache/pinot/pull/9740#discussion_r1017676767
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexHandler.java:
##########
@@ -39,4 +39,12 @@ void updateIndices(SegmentDirectory.Writer segmentWriter,
IndexCreatorProvider i
*/
boolean needUpdateIndices(SegmentDirectory.Reader segmentReader)
throws Exception;
+
+ /**
+ * Performs any cleanup actions required after the indexes have been updated.
+ * Should be called only after all IndexHandlers have run.
+ */
+ default void postUpdateIndicesCleanup(SegmentDirectory.Writer segmentWriter)
Review Comment:
Hmmm not sure if I follow this. Seems a bit confusing. If we want this to be
invoked only after all indexHandlers have run, then I don't think this API
should exist on `IndexHandler` interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
