somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1018015250
########## pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledMultiValueQueriesTestWithReload.java: ########## @@ -0,0 +1,525 @@ +/** Review Comment: Yes, there are only 2 MV columns in the avro file used in these tests. Today I disable them both (2 segments for 1 column and 1 segment for the other). It was very tricky to rewrite those tests to both keep my existing tests and add these new reload tests as I would need the `BeforeMethod` to essentially setup the segment differently for reload vs. non-reload tests. Or I would have to remove the forward index disabled flag for one of the columns for the non-reload tests and rewrite those tests. This gave me more flexibility to also disable dictionary for the second column etc. Let me know if you prefer that I consolidate the two and rewrite some of the test cases in the file to only assess forward index disabled for 1 column instead of two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
