Jackie-Jiang commented on code in PR #9642:
URL: https://github.com/apache/pinot/pull/9642#discussion_r1022645384
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/DataTypeTransformer.java:
##########
@@ -92,6 +92,13 @@ public GenericRow transform(GenericRow record) {
// Single-value column
source = PinotDataType.getSingleValueType(value.getClass());
}
+
+ if (source == PinotDataType.BYTES && dest == PinotDataType.STRING &&
value instanceof byte[]) {
Review Comment:
The only backward incompatibility is when user expects to store bytes as
string [123, 45, 6], which IMO should never happen, so I won't worry too much
about it. We don't want to specially handle it because it can break the case
when user expects to strong bytes as hex encoded string, which is the way we
support bytes before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
