snleee commented on code in PR #9642:
URL: https://github.com/apache/pinot/pull/9642#discussion_r1022117878
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/DataTypeTransformer.java:
##########
@@ -92,6 +92,13 @@ public GenericRow transform(GenericRow record) {
// Single-value column
source = PinotDataType.getSingleValueType(value.getClass());
}
+
+ if (source == PinotDataType.BYTES && dest == PinotDataType.STRING &&
value instanceof byte[]) {
Review Comment:
@Jackie-Jiang I briefly met with Sajjad and he mentioned that this type
change code won't be needed for new tables. But, he wants to keep the backward
compatibility for the existing tables (where the input data is Avro's Fixed
type column and Pinot is configured with `string`column ) since he cannot
afford the backfill right away.
I think that the challenge here is that we can only check if the source
value is `byte[]` type but we don't actually know if the value is originally
from `bytes` avro column or `fixed` column. And we have been handling those
differently.
@sajjad-moradi Can you provide more context to Jackie?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
